Skip to content

feat(telemetry): Add url data to operator updates on telemetry service#1136

Merged
JuArce merged 70 commits intostagingfrom
feat/telemetry-operator-url-data
Oct 16, 2024
Merged

feat(telemetry): Add url data to operator updates on telemetry service#1136
JuArce merged 70 commits intostagingfrom
feat/telemetry-operator-url-data

Conversation

@JulianVentura
Copy link
Copy Markdown
Contributor

@JulianVentura JulianVentura commented Oct 1, 2024 •
edited
Loading

Description

This PR adds new data to be updated for each operator on the telemetry service, which includes:

  • eth_rpc_url
  • eth_rpc_url_fallback
  • eth_ws_url
  • eth_ws_url_fallback
  • version (this one was already present)

The implementation is also updated from the operator's side.

Testing

In order to test, the following steps were taken:

  1. Start anvil and the aggregator with:
  • make anvil_start_with_block_time
  • make aggregator_start
  1. Build and register operator with:
  • make build_operator
  • make operator_full_registration CONFIG_FILE=config-files/config-operator-1.yaml
  1. Start telemetry service with:
  • make telemetry_clean_db
  • make telemetry_run_db
  • make telemetry_start
  1. Go to http://localhost:4001/api/operators and you should see the operator with its data fields. Some of them, like the version and RPC related should be set as null, since the operator is not up yet.
  2. Start the operator with ./operator/build/aligned-operator start --config ./config-files/config-operator-1.yaml
  3. Go to http://localhost:4001/api/operators and you should see the operator, now with all fields with a certain value, including version and RPC related.

It is also highly advisable to test previous functionality as it's described on this already merged PR

JuArce and others added 21 commits September 18, 2024 14:11
@JuArce
chore: initial telemetry api setup
475b43a 
feat: CRUD for operators version
@JuArce
chore: verify signature from operator
4bd1025
@JuArce
refactor: add comments to signature_verifier.ex
2df7f20
@JuArce
chore: update operator endpoint
74757b8
@JuArce
chore: add targets
7c8413e 
docs: update README
@JuArce
docs: update README.md
c63f797
@JuArce
chore: update Makefile
d53b6ae
@JuArce
feat: create and finish traces for specified merkle root
d0ccfa9
@avilagaston9
feat(tracker): update operators' version if they already exist (#1070)
9561780
@JulianVentura
feat: add operator identity check on registry manager contract before…
7bac49f 
… creation (#1080)

Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
@avilagaston9
feat(telemetry): modify the aggregator to use the elixir Tracker (#1105)
c796740
@JulianVentura
feat: Add operators data fetch at startup (#1108)
54eb9fb 
Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
@JuArce
Merge branch 'refs/heads/998-refactortracker-rewrite-operator_tracker…
2b6d382 
…-in-elixir' into 1075-feattelemetry-implement-telemetry-for-aggregator

# Conflicts:
#	telemetry_api/config/dev.exs
#	telemetry_api/mix.exs
#	telemetry_api/mix.lock
@JuArce
Merge branch 'refs/heads/staging' into 998-refactortracker-rewrite-op…
b99b9bf 
…erator_tracker-in-elixir
@JuArce
Merge branch 'refs/heads/998-refactortracker-rewrite-operator_tracker…
335a448 
…-in-elixir' into 1075-feattelemetry-implement-telemetry-for-aggregator
@JuArce
chore: upload mix lock
49b9646
@JuArce
fix: parse operator id correctly
f60ebf1 
fix: store address and operator_id in lowercase
@JuArce
Merge branch 'refs/heads/998-refactortracker-rewrite-operator_tracker…
948565c 
…-in-elixir' into 1075-feattelemetry-implement-telemetry-for-aggregator
Add operators url data update
fca58d2
@JuArce
fix: encode address to lowercase
57e0776
@JuArce
nit
8da05e6
@JulianVentura JulianVentura marked this pull request as ready for review October 1, 2024 21:14
@JulianVentura JulianVentura marked this pull request as draft October 1, 2024 21:42
@JulianVentura JulianVentura marked this pull request as ready for review October 2, 2024 14:54
avilagaston9
avilagaston9 reviewed Oct 2, 2024
View reviewed changes
Comment thread operator/cmd/actions/start.go Outdated
Comment thread operator/cmd/actions/start.go Outdated
Base automatically changed from 1075-feattelemetry-implement-telemetry-for-aggregator to staging October 10, 2024 16:12
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 14, 2024 •
edited
Loading

Changes to gas cost

Generated at commit: 1ba65813a42630c266a2fba6c6607917396efff6, compared to commit: 07f682c7f5bab0ef2711f7373ba865d4ef9d5258

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager createNewTask -24 ✅ -0.03%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 4,681,797 (0) createNewTask 53,859 (+24) +0.04% 73,818 (-24) -0.03% 73,963 (-18) -0.02% 74,821 (+36) +0.05% 256 (0)
RegistryCoordinatorHarness 5,846,028 (+17,275)

avilagaston9
avilagaston9 reviewed Oct 14, 2024
View reviewed changes
Comment thread telemetry_api/lib/telemetry_api_web/controllers/operator_controller.ex
MarcosNicolau
MarcosNicolau reviewed Oct 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my machine, and it worked fine. One thing, in the diff I see you changed the eigenlayer-middleware, is that on purpose?

@JulianVentura
Copy link
Copy Markdown
Contributor Author

JulianVentura commented Oct 14, 2024

Tested on my machine, and it worked fine. One thing, in the diff I see you changed the eigenlayer-middleware, is that on purpose?

No, I haven't touched anything related to that. There was a merge from staging branch, so maybe it was an auto merge error? eigenlayer-middleware is a submodule, I checked and the staging branch points to the same commit as this one, so Idk what caused that diff.

@JulianVentura
Copy link
Copy Markdown
Contributor Author

JulianVentura commented Oct 14, 2024

Tested on my machine, and it worked fine. One thing, in the diff I see you changed the eigenlayer-middleware, is that on purpose?

No, I haven't touched anything related to that. There was a merge from staging branch, so maybe it was an auto merge error? eigenlayer-middleware is a submodule, I checked and the staging branch points to the same commit as this one, so Idk what caused that diff.

My bad. The submodule commit was in fact different from the one in staging branch. Good catch!

entropidelic
entropidelic reviewed Oct 15, 2024
View reviewed changes
Comment thread operator/cmd/actions/utils.go Outdated
@entropidelic
Copy link
Copy Markdown
Contributor

entropidelic commented Oct 15, 2024 •
edited
Loading

everything worked correctly, but I am thinking that it does not make much sense to register the http and websocket providers URL separately. Since the protocol and the API key are stripped from the URL, they will always be the same, or am I missing something?
nvm, talked with @JuArce and the current behaviour is correct

avilagaston9
avilagaston9 reviewed Oct 15, 2024
View reviewed changes
Comment thread telemetry_api/lib/telemetry_api/operators.ex
avilagaston9
avilagaston9 reviewed Oct 15, 2024
View reviewed changes
Comment thread telemetry_api/lib/telemetry_api/operators.ex
uri-99
uri-99 approved these changes Oct 15, 2024
View reviewed changes
Comment thread operator/pkg/utils.go Outdated
Comment thread operator/pkg/utils_test.go
uri-99
uri-99 suggested changes Oct 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to request changes because of my previous comments. Everything else works

JuArce
JuArce requested changes Oct 16, 2024
View reviewed changes
Comment thread operator/cmd/actions/utils.go Outdated
Comment thread operator/cmd/actions/start.go Outdated
Comment thread operator/cmd/actions/start.go Outdated
@JuArce JuArce merged commit 8164a8f into staging Oct 16, 2024
@JuArce JuArce deleted the feat/telemetry-operator-url-data branch October 16, 2024 15:28
@JuArce JuArce mentioned this pull request Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuArce JuArce JuArce approved these changes

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

+4 more reviewers

@Oppen Oppen Oppen left review comments

@entropidelic entropidelic entropidelic left review comments

@avilagaston9 avilagaston9 avilagaston9 left review comments

@uri-99 uri-99 uri-99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JulianVentura JulianVentura

Labels

None yet

Projects

AlignedLayed Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@JulianVentura @entropidelic @Oppen @uri-99 @JuArce @avilagaston9 @MarcosNicolau